cap: add X2ApicApi capability. #333
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capability is used to program/remap MSI IRQ routing to vCPUs with IDs larger than 255. Signed-off-by: Peter Oskolkov <posk@google.com>
posk-io
requested review from
acatangiu,
andreeaflorescu,
lauralt,
sameo,
roypat and
ShadowCurse
as code owners
roypat
approved these changes
Jul 17, 2025
|
Let us know if you'll also new a patch release of kvm-ioctls to use this in cloud hypervisor :) |
ShadowCurse
approved these changes
Jul 17, 2025
Cloud Hypervisor depends on kvm-ioctls both directly and indirectly through vfio-ioctls. I think releasing just kvm-ioctls may not be enough... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capability is used to program/remap MSI IRQ routing to vCPUs with IDs larger than 255.
Summary of the PR
I'm working on a PR to Cloud Hypervisor to allow it to run VMs with more than 256 vCPUs. KVM on x86_64 needs KVM_CAP_X2APIC_API capability to properly route IRQs to CPUs with APIC IDs larger than 255; as Cloud Hypvervisor depends on this crate for KVM capability management, this small change is needed to avoid ugly workarounds.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test:
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.